Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve assertion and error handling #3

Open
eXpl0it3r opened this issue Jul 3, 2015 · 1 comment
Open

Improve assertion and error handling #3

eXpl0it3r opened this issue Jul 3, 2015 · 1 comment

Comments

@eXpl0it3r
Copy link
Contributor

Having taken a glance at the source code, it seems you use a lot of assert() calls. I can see that some are "correctly" used, e.g. when you check for a "contract", however there a lot of them are used for lazy error handling, which is in my opinion a rather bad practice and can lead to compiler warnings in release mode.

I personally prefer exceptions but some if statements would do the trick as well and if you just want to get rid of the compiler warning you could use some "unused macro".

@fallahn
Copy link
Owner

fallahn commented Jul 3, 2015

fair comment. I shall make an effort to tidy things up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants