Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

loremflickr.com seems to be behind an authwall now #2014

Closed
8 of 10 tasks
mcmxcdev opened this issue Apr 2, 2023 · 10 comments
Closed
8 of 10 tasks

loremflickr.com seems to be behind an authwall now #2014

mcmxcdev opened this issue Apr 2, 2023 · 10 comments
Labels
c: bug Something isn't working has workaround Workaround provided or linked m: image Something is referring to the image module wontfix This will not be worked on

Comments

@mcmxcdev
Copy link

mcmxcdev commented Apr 2, 2023

Pre-Checks

Describe the bug

Not sure if this is a temporary problem on their end or intentional, but we are unable to receive any images back anymore.

In our case, this is a problem when using faker.image.abstract() method.

Minimal reproduction code

No response

Additional Context

image

Environment Info

System:
    OS: Linux 6.2 Ubuntu 22.10 22.10 (Kinetic Kudu)
    CPU: (16) x64 AMD Ryzen 7 5800H with Radeon Graphics
    Memory: 8.37 GB / 30.72 GB
    Container: Yes
    Shell: 5.9 - /usr/bin/zsh
  Binaries:
    Node: 18.14.1 - ~/.volta/tools/image/node/18.14.1/bin/node
    npm: 9.3.1 - ~/.volta/tools/image/node/18.14.1/bin/npm
  Browsers:
    Brave Browser: 111.1.49.132
    Chrome: 111.0.5563.146
  npmPackages:
    @faker-js/faker: ^7.6.0 => 7.6.0

Which module system do you use?

  • CJS
  • ESM

Used Package Manager

pnpm

@mcmxcdev mcmxcdev added c: bug Something isn't working s: pending triage Pending Triage labels Apr 2, 2023
@EricAgnitsch
Copy link

I thought I was going crazy lol. I wonder if this issue needs to be opened https://github.com/xvladqt/Faker-LoremFlickr instead? Hasn't been committed to in 3 years though :/

@Eduardo-Julio
Copy link

I thought I was going crazy lol.

Yes, me too, our dev environment is not looking too good.

This is an alternative that seems solid https://picsum.photos/

@ST-DDT ST-DDT added the p: 2-high Fix main branch label Apr 3, 2023
@ST-DDT ST-DDT added this to the v8.0 - Module Re-Shuffling milestone Apr 3, 2023
@ST-DDT ST-DDT moved this to Todo in Faker Roadmap Apr 3, 2023
@ST-DDT ST-DDT added the has workaround Workaround provided or linked label Apr 3, 2023
@ST-DDT
Copy link
Member

ST-DDT commented Apr 3, 2023

In the upcoming v8 (currently only available as alpha) we have a new method explicitly for picsum photos.
https://next.fakerjs.dev/api/image.html#urlpicsumphotos

@ST-DDT
Copy link
Member

ST-DDT commented Apr 3, 2023

The ruby team has the same issue, so I link their issue here as well, maybe somebody knows what is going on there:

@matthewmayer
Copy link
Contributor

i sent a DM to https://twitter.com/MastaBaba who maintained it to see if this is a deliberate removal or a temporary bug

@ST-DDT ST-DDT moved this from Todo to In Progress in Faker Roadmap Apr 3, 2023
@ST-DDT ST-DDT added s: awaiting more info Additional information are requested and removed s: pending triage Pending Triage labels Apr 3, 2023
@matthewmayer
Copy link
Contributor

He replied

Hi. No. The hosting provider was having an issue. The site should be back up and running.

@ST-DDT ST-DDT added m: image Something is referring to the image module wontfix This will not be worked on and removed p: 2-high Fix main branch s: awaiting more info Additional information are requested labels Apr 3, 2023
@ST-DDT ST-DDT closed this as completed Apr 3, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in Faker Roadmap Apr 3, 2023
@Shinigami92
Copy link
Member

In the upcoming v8 (currently only available as alpha) we have a new method explicitly for picsum photos.

https://next.fakerjs.dev/api/image.html#urlpicsumphotos

Just for the protocol: this won't had worked for the user's need of 'abstract' category
Flickr is our only provider having categories

@matthewmayer
Copy link
Contributor

matthewmayer commented Apr 3, 2023

All the category methods are deprecated though right?

@Shinigami92
Copy link
Member

All the category methods are deprecated though right?

There is still urlLoremFlickr

@matthewmayer
Copy link
Contributor

matthewmayer commented Apr 3, 2023

The deprecation message for faker.image.abstract() etc points to faker.image.url() which doesn't support a category.

Maybe we should change that to point to faker.image.urlLoremFlickr instead then?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: bug Something isn't working has workaround Workaround provided or linked m: image Something is referring to the image module wontfix This will not be worked on
Projects
No open projects
Status: Done
Development

No branches or pull requests

6 participants