Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for python 3.12 (wip) #499

Closed
wants to merge 1 commit into from
Closed

Add support for python 3.12 (wip) #499

wants to merge 1 commit into from

Conversation

theoparis
Copy link

What does this PR do? Please describe:

I added python 3.12 support to prebuilt wheels. Unable to test locally at the moment.

Fixes #471

Does your PR introduce any breaking changes? If yes, please list them:

Check list:

  • Was the content of this PR discussed and approved via a GitHub issue? (no need for typos or documentation improvements)
  • Did you read the contributor guideline?
  • Did you make sure that your PR does only one thing instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests?
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (no need for typos, documentation, or minor internal changes)

@theoparis theoparis requested a review from cbalioglu as a code owner May 5, 2024 04:35
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 5, 2024
@theoparis theoparis mentioned this pull request May 5, 2024
Open
@cbalioglu
Copy link
Contributor

#713 713

@cbalioglu cbalioglu closed this Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cbalioglu cbalioglu Awaiting requested review from cbalioglu cbalioglu is a code owner

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pip3 install fairseq2 - doesn't work
3 participants
@theoparis @cbalioglu @facebook-github-bot