replace hcc with correct macro for rocm platforms #5192
Conversation
Summary: __HIP_PLATFORM_HCC__ is now removed from rocm-6.0. It should be __HIP_PLATFORM_AMD__.
|
Hi @gurpreet-dhami! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
facebook-github-bot
added
the
CLA Signed
|
@ezyang perhaps to land this trivial PR? |
|
@ezyang has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Summary:
__HIP_PLATFORM_HCC__is now removed from rocm-6.0 and should be__HIP_PLATFORM_AMD__.Thanks for your contribution!
If you're sending a large PR (e.g., >100 lines),
please open an issue first about the feature / bug, and indicate how you want to contribute.
We do not always accept features.
See https://detectron2.readthedocs.io/notes/contributing.html#pull-requests about how we handle PRs.
Before submitting a PR, please run
dev/linter.shto lint the code.