Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add 'expression.max_compiled_regexes' Query Config #11850

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: Add 'expression.max_compiled_regexes' Query Config #11850

wants to merge 1 commit into from
+185 −74

Conversation

spershin
Copy link
Contributor

Summary:
Adding 'expression.max_compiled_regexes' Query Config property, so it
can be adjusted per query.
Also increasing the dfault value to 100 from 20.

Differential Revision: D67183811

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 13, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D67183811

@netlify Netlify
Copy link

netlify bot commented Dec 13, 2024 •
edited
Loading

✅ Deploy Preview for meta-velox canceled.

Name Link
🔨 Latest commit e6522a1
🔍 Latest deploy log https://app.netlify.com/sites/meta-velox/deploys/675d17220de08700085eca50

@spershin spershin requested a review from xiaoxmeng December 13, 2024 05:35
spershin pushed a commit to spershin/velox-1 that referenced this pull request Dec 14, 2024
@facebook-github-bot
feat: Add 'expression.max_compiled_regexes' Query Config (facebookinc…
43e143b 
…ubator#11850)

Summary:

Adding 'expression.max_compiled_regexes' Query Config property, so it
can be adjusted per query.
Also increasing the dfault value to 100 from 20.

Differential Revision: D67183811
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D67183811

yuandagits
yuandagits approved these changes Dec 14, 2024
View reviewed changes
Copy link
Contributor

@yuandagits yuandagits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

super nit: Internally, I see most of them fail at 20, maybe 25 or 50 is a better starting point if there are concerns with high resource usage from 100?

there also seems to be an unrelated compile issue :(, I can try to patch it

@spershin
Copy link
Contributor Author

super nit: Internally, I see most of them fail at 20, maybe 25 or 50 is a better starting point if there are concerns with high resource usage from 100?

there also seems to be an unrelated compile issue :(, I can try to patch it

@yuandagits

Thanks for reviewing!

We don't know honestly what the limit would be enough for most of the queries.
The goal of this change:

  1. Expose a control lever, so we can play with it.
  2. 20 is too small a limit, use something bigger.

We can always adjust the default value later.
After this lands we will add Presto session property to control it per query.

Compile issue has been fixed in a different branch. It is only in macos build.

@facebook-github-bot
feat: Add 'expression.max_compiled_regexes' Query Config (facebookinc…
e6522a1 
…ubator#11850)

Summary:

Adding 'expression.max_compiled_regexes' Query Config property, so it
can be adjusted per query.
Also increasing the dfault value to 100 from 20.

Reviewed By: yuandagits

Differential Revision: D67183811
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D67183811

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuandagits yuandagits yuandagits approved these changes

@xiaoxmeng xiaoxmeng Awaiting requested review from xiaoxmeng

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@spershin @facebook-github-bot @yuandagits