This is what I meant to do

Simon Marlow · facebook-github-bot · commit 2e230943408c · 2025-01-17T06:41:29.000-08:00
Reviewed By: iamirzhan

Differential Revision: D68320468

fbshipit-source-id: 652b0c08782f285aeeb43c5a7663f54e73359891
diff --git a/glean/schema/cpp/schema.h b/glean/schema/cpp/schema.h
@@ -29613,7 +29613,7 @@ struct ArgumentValue : Predicate<boost::variant<Alt<0, std::string>, Alt<1, std:
 struct SCHEMA {
   template<typename P> struct index;
   static constexpr size_t count = 1321;
-  inline static std::string schemaId = "59d399727c5be908f526f7279d0e6ee1";
+  static constexpr char schemaId[] = "59d399727c5be908f526f7279d0e6ee1";
   template<size_t i> struct predicate;
 };
 
diff --git a/glean/schema/gen/Glean/Schema/Gen/Cpp.hs b/glean/schema/gen/Glean/Schema/Gen/Cpp.hs
@@ -88,7 +88,7 @@ defineSchema ds hash = do
         "static constexpr size_t count = "
           <> Text.pack (show $ length pnames)
           <> ";",
-        "inline static std::string schemaId = \"" <> unSchemaId hash <> "\";",
+        "static constexpr char schemaId[] = \"" <> unSchemaId hash <> "\";",
         "template<size_t i> struct predicate;"
       ]
     , ["};"]

Original file line number	Diff line number	Diff line change
`@@ -88,7 +88,7 @@ defineSchema ds hash = do`
`88`	`88`	`"static constexpr size_t count = "`
`89`	`89`	`<> Text.pack (show $ length pnames)`
`90`	`90`	`<> ";",`
`91`		`- "inline static std::string schemaId = \"" <> unSchemaId hash <> "\";",`
	`91`	`+ "static constexpr char schemaId[] = \"" <> unSchemaId hash <> "\";",`
`92`	`92`	`"template<size_t i> struct predicate;"`
`93`	`93`	`]`
`94`	`94`	`, ["};"]`