Remove chunking config from Graceful restart

Summary:
The `shouldChunkTakeoverData` config has been true for all the users for more than a month. See D86546274

This diff just remove this config to make the code cleaner.
Also, remove from `configerator` in D88687539

Reviewed By: vilatto

Differential Revision: D88685795

fbshipit-source-id: 7ac294233984726b77e6b210167729493dd00127

Author: kavehahmadi60

eden/fs/config/EdenConfig.h

@@ -253,16 +253,6 @@ class EdenConfig : private ConfigSettingManager {
       std::chrono::seconds(150),
       this};
 
-  /**
-   * Temporary config to control roll out of
-   * TakeoverCapabilities::CHUNKED_MESSAGE protocol
-   * Delete this config when rollout is 100% complete
-   */
-  ConfigSetting<bool> shouldChunkTakeoverData{
-      "core:should-chunk-takeover-data",
-      true,
-      this};
-
   /**
    * If EdenFS should auto migrate non inmemory inode catalogs to inmemory on
    * Windows.

eden/fs/service/EdenServer.cpp

@@ -2635,10 +2635,6 @@ void EdenServer::stop() {
   server_->stop();
 }
 
-bool EdenServer::shouldChunkTakeoverData() {
-  return serverState_->getEdenConfig()->shouldChunkTakeoverData.getValue();
-}
-
 folly::Future<TakeoverData> EdenServer::startTakeoverShutdown() {
 #ifndef _WIN32
   // Make sure we aren't already shutting down, then update our state

eden/fs/service/EdenServer.h

@@ -266,14 +266,6 @@ class EdenServer : private TakeoverHandler {
    */
   folly::Future<TakeoverData> startTakeoverShutdown() override;
 
-  /*
-   * This is a temporary function that override
-   * TakeoverCapabilities::CHUNKED_MESSAGE. We use it to control the protocol
-   * roll out through eden config. This function should remove after roll out
-   * completes to 100%
-   */
-  bool shouldChunkTakeoverData() override;
-
   /**
    * Mount and return an EdenMount.
    */

eden/fs/takeover/TakeoverHandler.h

@@ -39,14 +39,6 @@ class TakeoverHandler {
   virtual folly::Future<TakeoverData> startTakeoverShutdown() = 0;
 
   virtual void closeStorage() = 0;
-
-  /*
-   * This is a temporary function that override
-   * TakeoverCapabilities::CHUNKED_MESSAGE. We use it to control the protocol
-   * roll out through Eden config. This function should removed after the roll
-   * out has completed.
-   */
-  virtual bool shouldChunkTakeoverData() = 0;
 };
 
 } // namespace facebook::eden

eden/fs/takeover/TakeoverServer.cpp

@@ -201,9 +201,6 @@ Future<Unit> TakeoverServer::ConnHandler::start() noexcept {
             (currentState.protocolCapabilities &
              TakeoverCapabilities::CHUNKED_MESSAGE);
 
-        currentState.shouldChunk =
-            server_->getTakeoverHandler()->shouldChunkTakeoverData();
-
         return server_->getTakeoverHandler()->startTakeoverShutdown();
       })
       .via(server_->eventBase_)

eden/fs/takeover/test/TakeoverTest.cpp

@@ -45,14 +45,6 @@ class TestHandler : public TakeoverHandler {
 
   void closeStorage() override {}
 
-  bool shouldChunkTakeoverData() override {
-    /**
-     * shouldChunkTakeoverData() is a temporary function for rolling out
-     * TakeoverCapabilities::CHUNKED_MESSAGE protocol. In the test this value
-     * should be true to make sure tests cover chunked data */
-    return true;
-  }
-
  private:
   TakeoverData data_;
 };
@@ -67,14 +59,6 @@ class ErrorHandler : public TakeoverHandler {
         std::logic_error("purposely failing for testing"));
   }
   void closeStorage() override {}
-
-  bool shouldChunkTakeoverData() override {
-    /**
-     * shouldChunkTakeoverData() is a temporary function for rolling out
-     * TakeoverCapabilities::CHUNKED_MESSAGE protocol. In the test this value
-     * should be true to make sure tests cover chunked data */
-    return true;
-  }
 };
 
 /**