Skip to content

Commit 2ccca48

Browse files
committed
[compiler][be] Clean up bug + feature test fixtures
Test fixtures testing different compiler features (e.g. non-auto memoization) should live in separate directories. Remove bug-prefixed fixtures that have since been fixed
1 parent d325f87 commit 2ccca48

33 files changed

+21
-14
lines changed

compiler/packages/babel-plugin-react-compiler/src/__tests__/fixtures/compiler/bug-invalid-hoisting-functionexpr.expect.md compiler/packages/babel-plugin-react-compiler/src/__tests__/fixtures/compiler/hoisting-functionexpr-conditional-dep.expect.md

+3-1
Original file line numberDiff line numberDiff line change
@@ -90,4 +90,6 @@ export const FIXTURE_ENTRYPOINT = {
9090
};
9191

9292
```
93-
93+
94+
### Eval output
95+
(kind: ok) <div>{"shouldInvokeFns":true,"callback":{"kind":"Function","result":null}}</div>
Original file line numberDiff line numberDiff line change
@@ -85,4 +85,7 @@ export const FIXTURE_ENTRYPOINT = {
8585
};
8686

8787
```
88-
88+
89+
### Eval output
90+
(kind: ok) {}
91+
[[ (exception in render) TypeError: Cannot read properties of null (reading 'title_text') ]]
Original file line numberDiff line numberDiff line change
@@ -70,4 +70,8 @@ export const FIXTURE_ENTRYPOINT = {
7070
};
7171

7272
```
73-
73+
74+
### Eval output
75+
(kind: ok) [[ (exception in render) TypeError: Cannot read properties of null (reading 'b') ]]
76+
<div>{"fn":{"kind":"Function","result":null},"shouldInvokeFns":true}</div>
77+
<div>{"fn":{"kind":"Function","result":4},"shouldInvokeFns":true}</div>
+6-1
Original file line numberDiff line numberDiff line change
@@ -70,4 +70,9 @@ export const FIXTURE_ENTRYPOINT = {
7070
};
7171

7272
```
73-
73+
74+
### Eval output
75+
(kind: ok) ["null"]
76+
[null]
77+
[null]
78+
["null"]

compiler/packages/snap/src/SproutTodoFilter.ts

+3-10
Original file line numberDiff line numberDiff line change
@@ -477,22 +477,15 @@ const skipFilter = new Set([
477477
'invalid-jsx-lowercase-localvar',
478478

479479
// bugs
480-
'fbt/bug-fbt-plural-multiple-function-calls',
481-
'fbt/bug-fbt-plural-multiple-mixed-call-tag',
482-
`bug-capturing-func-maybealias-captured-mutate`,
483480
'bug-object-expression-computed-key-modified-during-after-construction-hoisted-sequence-expr',
484-
'bug-invalid-hoisting-functionexpr',
481+
`bug-capturing-func-maybealias-captured-mutate`,
485482
'bug-aliased-capture-aliased-mutate',
486483
'bug-aliased-capture-mutate',
487484
'bug-functiondecl-hoisting',
488-
'bug-try-catch-maybe-null-dependency',
489485
'bug-type-inference-control-flow',
490-
'reduce-reactive-deps/bug-infer-function-cond-access-not-hoisted',
486+
'fbt/bug-fbt-plural-multiple-function-calls',
487+
'fbt/bug-fbt-plural-multiple-mixed-call-tag',
491488
'bug-invalid-phi-as-dependency',
492-
'reduce-reactive-deps/bug-merge-uncond-optional-chain-and-cond',
493-
'original-reactive-scopes-fork/bug-nonmutating-capture-in-unsplittable-memo-block',
494-
'original-reactive-scopes-fork/bug-hoisted-declaration-with-scope',
495-
'bug-codegen-inline-iife',
496489

497490
// 'react-compiler-runtime' not yet supported
498491
'flag-enable-emit-hook-guards',

0 commit comments

Comments
 (0)