Lift dynamic prop merging to ConcreteComponentDescriptor #48939
+15
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D68633985 |
dmytrorykun
force-pushed
the
export-D68633985
branch
from
54cb5c2 to
7f9a459
Compare
dmytrorykun
added a commit
to dmytrorykun/react-native
that referenced
this pull request
Jan 27, 2025
) Summary: The `enableAccumulatedUpdatesInRawPropsAndroid` experiment needs additional context for finer setup. Specifically it needs to be conditionally enabled based on a component name. This information is not accessible form the `Props` constructor. This diff moves the experimental logic to `ConcreteComponentDescriptor`. Changelog: [Internal] Differential Revision: D68633985
|
This pull request was exported from Phabricator. Differential Revision: D68633985 |
dmytrorykun
added a commit
to dmytrorykun/react-native
that referenced
this pull request
Jan 27, 2025
) Summary: Pull Request resolved: facebook#48939 The `enableAccumulatedUpdatesInRawPropsAndroid` experiment needs additional context for finer setup. Specifically it needs to be conditionally enabled based on a component name. This information is not accessible form the `Props` constructor. This diff moves the experimental logic to `ConcreteComponentDescriptor`. Changelog: [Internal] Differential Revision: D68633985
dmytrorykun
added a commit
to dmytrorykun/react-native
that referenced
this pull request
Jan 27, 2025
) Summary: The `enableAccumulatedUpdatesInRawPropsAndroid` experiment needs additional context for finer setup. Specifically it needs to be conditionally enabled based on a component name. This information is not accessible form the `Props` constructor. This diff moves the experimental logic to `ConcreteComponentDescriptor`. Changelog: [Internal] Differential Revision: D68633985
dmytrorykun
force-pushed
the
export-D68633985
branch
from
7f9a459 to
97690b6
Compare
|
This pull request was exported from Phabricator. Differential Revision: D68633985 |
dmytrorykun
added a commit
to dmytrorykun/react-native
that referenced
this pull request
Jan 27, 2025
…acebook#48939) Summary: The `enableAccumulatedUpdatesInRawPropsAndroid` experiment needs additional context for finer setup. Specifically it needs to be conditionally enabled based on a component name. This information is not accessible form the `Props` constructor. This diff moves the experimental logic to `ConcreteComponentDescriptor`. Changelog: [Internal] Differential Revision: D68633985
dmytrorykun
added a commit
to dmytrorykun/react-native
that referenced
this pull request
Jan 28, 2025
…acebook#48939) Summary: The `enableAccumulatedUpdatesInRawPropsAndroid` experiment needs additional context for finer setup. Specifically it needs to be conditionally enabled based on a component name. This information is not accessible form the `Props` constructor. This diff moves the experimental logic to `ConcreteComponentDescriptor`. Changelog: [Internal] Differential Revision: D68633985
dmytrorykun
force-pushed
the
export-D68633985
branch
from
97690b6 to
d523933
Compare
dmytrorykun
added a commit
to dmytrorykun/react-native
that referenced
this pull request
Jan 28, 2025
) Summary: The `enableAccumulatedUpdatesInRawPropsAndroid` experiment needs additional context for finer setup. Specifically it needs to be conditionally enabled based on a component name. This information is not accessible form the `Props` constructor. This diff moves the experimental logic to `ConcreteComponentDescriptor`. Changelog: [Internal] Differential Revision: D68633985
|
This pull request was exported from Phabricator. Differential Revision: D68633985 |
) Summary: The `enableAccumulatedUpdatesInRawPropsAndroid` experiment needs additional context for finer setup. Specifically it needs to be conditionally enabled based on a component name. This information is not accessible form the `Props` constructor. This diff moves the experimental logic to `ConcreteComponentDescriptor`. Changelog: [Internal] Differential Revision: D68633985
dmytrorykun
force-pushed
the
export-D68633985
branch
from
d523933 to
25ba26f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D68633985 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The
enableAccumulatedUpdatesInRawPropsAndroidexperiment needs additional context for finer setup. Specifically it needs to be conditionally enabled based on a component name. This information is not accessible form thePropsconstructor.This diff moves the experimental logic to
ConcreteComponentDescriptor.Changelog: [Internal]
Differential Revision: D68633985