Run the enableAccumulatedUpdatesInRawPropsAndroid QE for View only #48852
+170
−42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D68492332 |
|
This pull request was exported from Phabricator. Differential Revision: D68492332 |
dmytrorykun
added a commit
to dmytrorykun/react-native
that referenced
this pull request
Jan 24, 2025
…acebook#48852) Summary: Pull Request resolved: facebook#48852 The `enableAccumulatedUpdatesInRawPropsAndroid` param will be tested together with the `enablePropsUpdateReconciliationAndroid` param. `enablePropsUpdateReconciliationAndroid` currently only supports `View` components. This diff changes `enableAccumulatedUpdatesInRawPropsAndroid` to also run only for `View`s. Differential Revision: D68492332
dmytrorykun
force-pushed
the
export-D68492332
branch
from
c11fe68 to
17eb0cd
Compare
|
This pull request was exported from Phabricator. Differential Revision: D68492332 |
dmytrorykun
added a commit
to dmytrorykun/react-native
that referenced
this pull request
Jan 27, 2025
…acebook#48852) Summary: Pull Request resolved: facebook#48852 The `enableAccumulatedUpdatesInRawPropsAndroid` param will be tested together with the `enablePropsUpdateReconciliationAndroid` param. `enablePropsUpdateReconciliationAndroid` currently only supports `View` components. This diff changes `enableAccumulatedUpdatesInRawPropsAndroid` to also run only for `View`s. Differential Revision: D68492332
dmytrorykun
force-pushed
the
export-D68492332
branch
from
17eb0cd to
6a25fbe
Compare
dmytrorykun
added a commit
to dmytrorykun/react-native
that referenced
this pull request
Jan 27, 2025
…acebook#48852) Summary: The `enableAccumulatedUpdatesInRawPropsAndroid` param will be tested together with the `enablePropsUpdateReconciliationAndroid` param. `enablePropsUpdateReconciliationAndroid` currently only supports `View` components. This diff changes `enableAccumulatedUpdatesInRawPropsAndroid` to also run only for `View`s. Differential Revision: D68492332
dmytrorykun
force-pushed
the
export-D68492332
branch
from
6a25fbe to
9bf7f33
Compare
|
This pull request was exported from Phabricator. Differential Revision: D68492332 |
…acebook#48939) Summary: The `enableAccumulatedUpdatesInRawPropsAndroid` experiment needs additional context for finer setup. Specifically it needs to be conditionally enabled based on a component name. This information is not accessible form the `Props` constructor. This diff moves the experimental logic to `ConcreteComponentDescriptor`. Changelog: [Internal] Differential Revision: D68633985
…acebook#48852) Summary: The `enableAccumulatedUpdatesInRawPropsAndroid` param will be tested together with the `enablePropsUpdateReconciliationAndroid` param. `enablePropsUpdateReconciliationAndroid` currently only supports `View` components. This diff changes `enableAccumulatedUpdatesInRawPropsAndroid` to also run only for `View`s. Differential Revision: D68492332
dmytrorykun
force-pushed
the
export-D68492332
branch
from
9bf7f33 to
d194c5e
Compare
|
This pull request was exported from Phabricator. Differential Revision: D68492332 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The
enableAccumulatedUpdatesInRawPropsAndroidparam will be tested together with theenablePropsUpdateReconciliationAndroidparam.enablePropsUpdateReconciliationAndroidcurrently only supportsViewcomponents.This diff changes
enableAccumulatedUpdatesInRawPropsAndroidto also run only forViews.Differential Revision: D68492332