Remove unnecessary interpolation for logcat logging #48567
Closed
+8
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D67461225 |
javache
added a commit
to javache/react-native
that referenced
this pull request
Jan 9, 2025
Summary: We don't need the `FBLOG_PRI` macro which does unnecessary additional interpolation, and can instead directly call `__android_log_write` Changelog: [Internal] Differential Revision: D67461225
javache
added a commit
to javache/react-native
that referenced
this pull request
Jan 9, 2025
Summary: We don't need the `FBLOG_PRI` macro which does unnecessary additional interpolation, and can instead directly call `__android_log_write` Changelog: [Internal] Differential Revision: D67461225
javache
added a commit
to javache/react-native
that referenced
this pull request
Jan 9, 2025
…ok#48567) Summary: We don't need the `FBLOG_PRI` macro which does unnecessary additional interpolation, and can instead directly call `__android_log_write` Changelog: [Internal] Differential Revision: D67461225
javache
added a commit
to javache/react-native
that referenced
this pull request
Jan 9, 2025
Summary: We don't need the `FBLOG_PRI` macro which does unnecessary additional interpolation, and can instead directly call `__android_log_write` Changelog: [Internal] Differential Revision: D67461225
javache
added a commit
to javache/react-native
that referenced
this pull request
Jan 9, 2025
Summary: We don't need the `FBLOG_PRI` macro which does unnecessary additional interpolation, and can instead directly call `__android_log_write` Changelog: [Internal] Differential Revision: D67461225
Summary: We don't need the `FBLOG_PRI` macro which does unnecessary additional interpolation, and can instead directly call `__android_log_write` Changelog: [Internal] Reviewed By: NickGerleman Differential Revision: D67461225
javache
force-pushed
the
export-D67461225
branch
from
33ba4b4 to
3f1412a
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67461225 |
|
This pull request has been merged in b0466d8. |
|
This pull request was successfully merged by @javache in b0466d8 When will my fix make it into a release? | How to file a pick request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
We don't need the
FBLOG_PRImacro which does unnecessary additional interpolation, and can instead directly call__android_log_writeChangelog: [Internal]
Differential Revision: D67461225