Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extra line wrap on some Android devices on some combinations of lineHeight, letterSpacing and other related properties #46436

Open
matejkriz opened this issue Sep 11, 2024 · 1 comment
Labels
Issue: Author Provided Repro This issue can be reproduced in Snack or an attached project. Platform: Android Android applications.

Comments

@matejkriz
Copy link

matejkriz commented Sep 11, 2024

Description

On some Android devices (for example Redmi 10C or Pixel 6 Pro) text is a measuring bug when setting both lineHeight and letterSpacing.

Some specific combinations of fontScale, lineHeight, maxFontSizeMultiplier, letterSpacing, fontFamily and also on the text causes extra line wrap.

In our case, it was possible to "fix" it by removing maxFontSizeMultiplier or letterSpacing or lineHeight.

But as a workaround we set allowFontScaling={false} and do the font scaling manually (setting fontSize and lineHeight by the fontScale).

image

Already reported #35039 but closed

Steps to reproduce

  1. Open Snack link https://snack.expo.dev/@matejkriztrezor/line-break-bug-demo
  2. Choose Android
  3. Switch to Pixel 6 Pro
  4. Launch Snack

React Native Version

0.75.2

Affected Platforms

Runtime - Android

Output of npx react-native info

System:
  OS: macOS 14.5
  CPU: (8) arm64 Apple M1 Pro
  Memory: 144.11 MB / 32.00 GB
  Shell:
    version: "5.9"
    path: /bin/zsh
Binaries:
  Node:
    version: 20.12.2
    path: ~/.nvm/versions/node/v20.12.2/bin/node
  Yarn:
    version: 4.2.2
    path: /opt/homebrew/bin/yarn
  npm:
    version: 10.5.0
    path: ~/.nvm/versions/node/v20.12.2/bin/npm
  Watchman:
    version: 2024.04.08.00
    path: /opt/homebrew/bin/watchman
Managers:
  CocoaPods:
    version: 1.12.1
    path: /Users/matejkriz/.rbenv/shims/pod
SDKs:
  iOS SDK:
    Platforms:
      - DriverKit 23.5
      - iOS 17.5
      - macOS 14.5
      - tvOS 17.5
      - visionOS 1.2
      - watchOS 10.5
  Android SDK:
    API Levels:
      - "29"
      - "30"
      - "31"
      - "33"
      - "34"
    Build Tools:
      - 29.0.2
      - 30.0.2
      - 30.0.3
      - 31.0.0
      - 33.0.0
      - 33.0.1
      - 33.0.2
      - 34.0.0
    System Images:
      - android-28 | Google ARM64-V8a Play ARM 64 v8a
      - android-29 | Google Play ARM 64 v8a
      - android-31 | Google Play ARM 64 v8a
      - android-33 | Google APIs ARM 64 v8a
      - android-33 | Google Play ARM 64 v8a
      - android-34 | Google Play ARM 64 v8a
    Android NDK: Not Found
IDEs:
  Android Studio: 2024.1 AI-241.18034.62.2412.12266719
  Xcode:
    version: 15.4/15F31d
    path: /usr/bin/xcodebuild
Languages:
  Java:
    version: 17.0.10
    path: /usr/bin/javac
  Ruby:
    version: 3.2.1
    path: /Users/matejkriz/.rbenv/shims/ruby
npmPackages:
  "@react-native-community/cli": Not Found
  react: Not Found
  react-native: Not Found
  react-native-macos: Not Found
npmGlobalPackages:
  "*react-native*": Not Found
Android:
  hermesEnabled: true
  newArchEnabled: false
iOS:
  hermesEnabled: true
  newArchEnabled: false

Stacktrace or Logs

there is no crash, only UI bug

Reproducer

https://snack.expo.dev/@matejkriztrezor/line-break-bug-demo?platform=android

import React from 'react';
import {Text, View} from 'react-native';

export default () => (
  <View style={{flexDirection: 'row'}}>
    <Text
      style={{
        letterSpacing: 1.6,
        lineHeight: 21,
      }}>
      0123456789
    </Text>
  </View>
);

Screenshots and Videos

image
@react-native-bot react-native-bot added the Platform: Android Android applications. label Sep 11, 2024
matejkriz added a commit to trezor/trezor-suite that referenced this issue Sep 11, 2024
On some Android devices (reported from Xiaomi) there were extra line breaks on some places i.e. portfolio balance, dashboard asset fiat value.

Only some specific values had that bug and only on some font scales.

Bug reported facebook/react-native#46436

As a workaround automatic font scaling is disabled and handled manually.
@cortinico cortinico added Issue: Author Provided Repro This issue can be reproduced in Snack or an attached project. and removed Needs: Triage 🔍 labels Sep 11, 2024
@young-st511
Copy link

I experienced this issue too. Thank you for fixing it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue: Author Provided Repro This issue can be reproduced in Snack or an attached project. Platform: Android Android applications.
Projects
None yet
Development

No branches or pull requests

4 participants