Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proxygen fails to build when a newer glog package is installed #488

Closed
jmccl opened this issue Mar 10, 2024 · 1 comment
Closed

proxygen fails to build when a newer glog package is installed #488

jmccl opened this issue Mar 10, 2024 · 1 comment

Comments

@jmccl
Copy link
Contributor

jmccl commented Mar 10, 2024

from /home/john/third-party/proxygen/proxygen/_build/deps/folly/folly/CancellationToken.cpp:17:
/usr/include/glog/logging.h:60:4: error: #error <glog/logging.h> was not included correctly. See the documention for how to consume the library.
   60 | #  error <glog/logging.h> was not included correctly. See the documention for how to consume the library.
      |    ^~~~~
In file included from /usr/include/glog/logging.h:63:

It seems basically due to this.

facebook/folly#2149, which references the glog commit.

Having said that, my assumption is something in proxygen likely will need to change as well.

@afrind
Copy link
Contributor

afrind commented Sep 18, 2024

Since this seems to be a folly problem first, closing this out. The folly issues mention an AUR patch that can get you past it. If you end up stuck with folly building but proxygen blocked, please reopen or file a new issue.

@afrind afrind closed this as completed Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants