-
Notifications
You must be signed in to change notification settings - Fork 648
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update documentation on using custom Hermes builds #1241
Comments
IIRC, there is a way to tell RN to build Hermes from a different directory. I don't remember the details, but someone will probably chime in here. BTW (and I don't know whether that is your use case), Hermes should not be used to run untrusted JS. For untrusted JS we have a security sandbox (which will make its way to GitHub soon). |
Hey @matias-la, we've recently discussed this in facebook/react-native#38658. You should be able to follow the steps there to get Hermes building from source. |
Thanks! We ended up using an approach similar to |
Summary: Original Author: [email protected] Original Git: 3d6e181 Original Reviewed By: cipolleschi Original Revision: D53398699 Fixes #1241 Pull Request resolved: #1297 Pulled By: cortinico Reviewed By: avp Differential Revision: D54092042 fbshipit-source-id: c0a9f28be1345707ba308b2bd8af39804d06f5db
fwiw we're working on applying some security hardening patches (hardened JS / Secure EcmaScript) on top of the upstream Hermes version too via a shim (tracking here if interested or any overlap), to trust the JS is free from prototype pollution (then sandbox RN app dependencies next) |
we had success this way too ^ thought might be worth mentioning in case anyone thinking about cherry picking static_h or hermes commits on top of your trusted source fork/repo, the change may not be backwards-compatible (we're working around this), but ofc Static Hermes will be when it ships |
Description
The Using a custom Hermes build in a React Native app documentation section hasn't been updated in a while. It dates back to the time when Hermes was shipped through a separate NPM package. But since the changes documented in Bundled Hermes occurred, this is no longer true and Hermes is bundled together with the react-native package. It isn't clear how it would be possible to run our application using a custom Hermes build.
Context about this request: we're running a security-sensitive RN app, so we'd like to apply some security hardening patches on top of the upstream Hermes version. But it's unclear how we'd be able to do this.
CC @cortinico
The text was updated successfully, but these errors were encountered: