Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@docusaurus/eslint-plugin is not compatible with ESLint 9 #10490

Open
1 of 2 tasks
Zamiell opened this issue Sep 11, 2024 · 4 comments
Open
1 of 2 tasks

@docusaurus/eslint-plugin is not compatible with ESLint 9 #10490

Zamiell opened this issue Sep 11, 2024 · 4 comments
Labels
bug An error in the Docusaurus core causing instability or issues with its execution

Comments

@Zamiell
Copy link
Contributor

Zamiell commented Sep 11, 2024

Have you read the Contributing Guidelines on issues?

Description

See this dependency: https://github.com/facebook/docusaurus/blob/main/packages/eslint-plugin/package.json#L24

This needs to be upgraded to max, or else satisfying the peer deps is impossible on ESLint 9.

  • I'd be willing to fix this bug myself.
@Zamiell Zamiell added bug An error in the Docusaurus core causing instability or issues with its execution status: needs triage This issue has not been triaged by maintainers labels Sep 11, 2024
@slorber slorber removed the status: needs triage This issue has not been triaged by maintainers label Sep 11, 2024
@slorber
Copy link
Collaborator

slorber commented Sep 11, 2024

Thanks

I didn't have time to study the problem, but is the change retro-compatible and can be done in a minor?

@Josh-Cena you probably have an idea?

@Josh-Cena
Copy link
Collaborator

I haven't updated a plugin to ESLint v9 so I don't know if that would suffice, but so I hope. Does flat config require a new recommended config format?

@Zamiell
Copy link
Contributor Author

Zamiell commented Sep 11, 2024

Not sure.

@Josh-Cena
Copy link
Collaborator

For now, let's include v9 in the peer dep range, and then people can try it out. Worst case they would need to apply workarounds like they already do with other plugins like plugin-react-hooks. Once I become more informed about how shared flat configs work, we can make it a new entry point like many other plugins are doing, and none of these changes would be semver breaking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An error in the Docusaurus core causing instability or issues with its execution
Projects
None yet
Development

No branches or pull requests

3 participants