Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[py-tx][hack] Implement NCMEC Upvote/Downvote in reference API #1614

Open
Dcallies opened this issue Aug 21, 2024 · 0 comments
Open

[py-tx][hack] Implement NCMEC Upvote/Downvote in reference API #1614

Dcallies opened this issue Aug 21, 2024 · 0 comments
Assignees
Labels
hackathon Included as part of a recent hackathon ncmec Pertaining to the NCMEC Hash API or cybertips python-threatexchange Items related to the threatexchange python tool / library

Comments

@Dcallies
Copy link
Contributor

NCMEC has added a new API to "upvote" and "downvote" hash entries.

Add a simple implementation to call that API. Here's the documentation: https://report.cybertip.org/hashsharing/v2/documentation/ (ctrl+f vote).

You won't be able to get NCMEC credentials, but @Dcallies can test that the implementation is right by patching your PR and using Meta's test API access.

The PR should include a unittest that mocks the NCMEC API response, and potentially updating the existing test response to include feedback data: https://github.com/facebook/ThreatExchange/blob/main/python-threatexchange/threatexchange/exchanges/clients/ncmec/tests/test_hash_api.py#L38

@Dcallies Dcallies added python-threatexchange Items related to the threatexchange python tool / library ncmec Pertaining to the NCMEC Hash API or cybertips labels Aug 21, 2024
@Dcallies Dcallies changed the title [py-tx] Implement NCMEC Upvote/Downvote in reference API [py-tx][hack] Implement NCMEC Upvote/Downvote in reference API Oct 1, 2024
@Dcallies Dcallies self-assigned this Oct 1, 2024
@Dcallies Dcallies added the hackathon Included as part of a recent hackathon label Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hackathon Included as part of a recent hackathon ncmec Pertaining to the NCMEC Hash API or cybertips python-threatexchange Items related to the threatexchange python tool / library
Projects
Status: No status
Development

Successfully merging a pull request may close this issue.

2 participants