Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[omm][onboarding] Initial setup issues #1504

Open
Sam-Freeman opened this issue Jan 10, 2024 · 2 comments
Open

[omm][onboarding] Initial setup issues #1504

Sam-Freeman opened this issue Jan 10, 2024 · 2 comments
Assignees
Labels
bug hma Items related to the hasher-matcher-actioner system successful reproduction This bug has a consistent reproduction

Comments

@Sam-Freeman
Copy link

Howdy! Just wanted to flag a couple of difficulties (and workarounds) that I noticed when getting OMM running locally for the first time. Happy to put a fix up for some of them, just wanted to put it down as an issue (to help me remember more than anything lol)

Seeding:

  • If you haven't seeded before, then the initial bank doesn't exist, and need to pass True to the storage.bank_update
  • In the for loop for adding examples, currently passing a dictionary of strings for key+value when it should be SignalType for the key
    • i.e. storage.bank_add_content(bank_name, {st.get_name(): example}) needs to become storage.bank_add_content(bank_name, {st: example})

Create App:

  • Not entirely sure why (haven't look into it yet), but, I had to comment out a bunch of lines around registering the blueprints the first time I created the app, afterwards, it was completely fine.
@Dcallies
Copy link
Contributor

Hey @Sam-Freeman, thanks for the report! If Cinder is considering a standing deployment in your tooling, also check out #1440 to help us prioritize requests.

We definitely accept pull requests if fixes look straightforward!

For your environment, were you running these in the docker devcontainer?

Seeding issues

Is this in the flask seed helper?

Create app

I've noticed issues that sometimes crop up with the templates directory acting bizarre, which only fix themselves after a full container rebuild.

If you can get a repro, paste some of the log messages here!

@Dcallies Dcallies self-assigned this Jan 11, 2024
@Dcallies Dcallies added bug hma Items related to the hasher-matcher-actioner system labels Jan 11, 2024
@Dcallies Dcallies added the successful reproduction This bug has a consistent reproduction label Jan 17, 2024
@Dcallies Dcallies assigned juanmrad and unassigned Dcallies Mar 14, 2024
@juanmrad
Copy link
Collaborator

I was not able to repro this after the latest fix for migration code and init of the app.

@Sam-Freeman are you able to check this is still the case if this is still an issue could you add some screenshot of errors?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug hma Items related to the hasher-matcher-actioner system successful reproduction This bug has a consistent reproduction
Projects
None yet
Development

No branches or pull requests

3 participants