Skip to content

CSS Enhancements  #19

@itsina96

Description

@itsina96

How could the project be improved

  • More detailed README, e.g. need to npm install etc
  • At some point it will be worth considering refactoring your CSS with rem (pixels hard codes things like button height) and ensure em is only used where explicitly related to font size - and avoid setting these with px
  • 'How does it work' text - more attention could be bought to this by making the text bigger. Also, the arrow next to the text makes it unclear whether this is a dropdown menu for the user to click on
  • The answers text in the FAQs should be formatted differently, e.g. the questions could be in bold. However, another option would be to remove the FAQs section and just add the information elsewhere in the relevant sections or under 'How it works'
  • Individual underlines for the title, time, comments and rating (a tags) when they only direct to one endpoint and have them all highlighted in red when clicked feels a little bit awkward: maybe text-decoration: none for time, comments and rating?
  • Cursor: pointer; on go to workshops
  • Bigger text - also maybe set it once in one place rather than in every elements?
  • Maybe burger menu for navigation - so slide in and out
  • Could abstract your styled components into a neighbouring file to separate the styling
  • It also looks like there is a lot of button styling that makes small changes, it might be worth considering a more standardised styling across components that they can then share

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions