Unable to get nested errors messages type when schema type is passed in flatten

[vladshcherbin]

I've tried switching from GenericSchema to ObjectSchema, checked suggested way in other issues and passed Schema type to flatten. For whatever reason the message type is unknown

Playground example

Error messages type:

If I remove Schema from flatten the type is array of strings:

Playground example

Is there a correct method that matches this types with schema defined?

valibot - 1.0.0-beta.9

[fabian-hiller]

Schema is a generic ObjectSchema and will never be strongly typed. Therefore, passing Schema to flatten has no advantage. What behavior did you expect? Maybe there is something we can do better. We can try to produce a more useful type that does not resolve to [string, unknown][].

[vladshcherbin]

@fabian-hiller in one of issue code blocks I saw you've used it this way, that's why I've tried the same in my project and got to this question. I didn't specify schema type before in flatten.

Since you've said there's no advantage I'd consider this resolved 🙌

p.s. It would be awesome if type was the same for schema/no schema to avoid such questions, but I'd consider this as low priority and this issue can serve as a reference

[fabian-hiller]

I reopen it because I would like to have a look at it in the next weeks.

[fabian-hiller]

I have investigated this issue further. It seems that this problem only occurs when using a generic. Therefore, it is probably not a problem we can fix simply by changing the type implementation of flatten. At least I have not found a solution yet. The following example works as expected without a generic.

import * as v from 'valibot';

const flatErrors = v.flatten<v.ObjectSchema<v.ObjectEntries, undefined>>([] as any);
if (flatErrors.nested) {
  const errors = Object.entries(flatErrors.nested); // [string, [string, ...string[]] | undefined][]
}

[fabian-hiller]

I am closing this issue as I am not sure if there is anything we can do, but if we find a possible solution in the future, I will be happy to reopen it.