Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Result filter does not affect neither error nor warning counts #23

Open
nikolaykasyanov opened this issue Apr 16, 2021 · 2 comments
Open

Result filter does not affect neither error nor warning counts #23

nikolaykasyanov opened this issue Apr 16, 2021 · 2 comments

Comments

@nikolaykasyanov
Copy link

Hi, thanks for this plugin!

I'd like to ask if it's intended behaviour or not that filter does not affect neither errorsCount nor warningsCount properties of XCodeSummary?
@sudeepdunzo
Copy link

+1 , also there is no way to get warnings array to filter it out on our own

@f-meloni
Copy link
Owner

f-meloni commented Jun 1, 2021

Hey 👋🏻
The filter option is been added later than the warning count, so that is not really intended, given they are totally indipendent I would be open to having the filter on errorsCount and warningsCount as well

@theScud theScud mentioned this issue Nov 10, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nikolaykasyanov @f-meloni @sudeepdunzo