Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature request: improved symbolic link support #76

Open
JasonWoof opened this issue Aug 23, 2013 · 2 comments
Open

feature request: improved symbolic link support #76

JasonWoof opened this issue Aug 23, 2013 · 2 comments

Comments

@JasonWoof
Copy link

Before I was wise in the ways of ftp, I created several sites with a symbolic link in the root folder which points to a file in a submodule.

When I upload a site with such a configuration, it initially works perfectly. git-ftp uploads the symbink with no special treatment, and it shows up on the server as a copy of the file (ie dereferenced.)

All's well and good so far.

Trouble is, when I update the file in the submodule that the link points to, and git ftp push again, it doesn't re-upload the symbolic link. So then the copy on the server (the one that's a symbolic link on my home computer) is out of date.

My request: make it so git-ftp would upload the symbolic link again, when the file it links to is uploaded. And in particular that this works even if the target is in a submodule.

I hope that's clear.

Thank you for this very handy program!

@ezyang
Copy link
Owner

ezyang commented Aug 23, 2013

Hmm, the real problem here is git-ftp doesn't know about symbolic links, so it is not uploading a symbolic link, it is uploading a copy of the file. It would be rather difficult to reverse engineer all of the places which might need to get updated, so probably a better solution is to arrange that a symbolic link is actually created on the other end. But to add insult to injury, FTP doesn't actually support creating symlinks natively. So I'm not even sure what I would do here.

@JasonWoof
Copy link
Author

oh dear... I meant to report this bug agaist resmo's git-ftp. Not sure why I went with that one. I'm a little terrified about the number shell escaping bugs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants