Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make single_parameter_details into a case-class/variant? #34

Open
eyalroz opened this issue Jul 4, 2022 · 0 comments
Open

Make single_parameter_details into a case-class/variant? #34

eyalroz opened this issue Jul 4, 2022 · 0 comments
Labels
question Further information is requested

Comments

@eyalroz
Copy link
Owner

eyalroz commented Jul 4, 2022

The single_parameter_details class currently has fields which are redundant/null for scalars, and other fields which are redundant/null for buffers. Let's make this struct into a case-class or variant, which can be initialized by specifying its kind (buffer/scalar) and only the nece

An alternative to doing this would be creating named constructor idioms for scalars and for buffers - which would reduce the amount of code necessary for the class itself.

@eyalroz eyalroz added the question Further information is requested label Jul 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant