From 6c7828bec8d384cb0c2ba2be9fada1c869c12918 Mon Sep 17 00:00:00 2001 From: Phil Pluckthun Date: Thu, 19 Sep 2024 21:00:38 +0100 Subject: [PATCH] Fix worker asset upload error not being shown --- CHANGELOG.md | 2 ++ packages/eas-cli/src/worker/upload.ts | 10 +++++----- 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 90f81b527d..d9279fe8d2 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -14,6 +14,8 @@ This is the log of notable changes to EAS CLI and related packages. ### ๐Ÿ› Bug fixes +- Fix typo causing `worker:deploy` asset upload errors not to be shown properly. + ### ๐Ÿงน Chores ## [12.4.1](https://github.com/expo/eas-cli/releases/tag/v12.4.1) - 2024-09-14 diff --git a/packages/eas-cli/src/worker/upload.ts b/packages/eas-cli/src/worker/upload.ts index 3b90978784..d8e82c4be4 100644 --- a/packages/eas-cli/src/worker/upload.ts +++ b/packages/eas-cli/src/worker/upload.ts @@ -165,13 +165,13 @@ export async function* batchUploadAsync( } yield await Promise.race(queue); } - } catch (error: any) { - if (typeof error !== 'object' || error.name !== 'AbortError') { - throw error; - } - } finally { + if (queue.size > 0) { controller.abort(); } + } catch (error: any) { + if (error.name !== 'AbortError') { + throw error; + } } }