Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Porting explosion/spaCy#12181 solution into weasel #83

Merged
merged 3 commits into from
Mar 25, 2024

Conversation

jeffrey12cali
Copy link
Contributor

Description

Resolves #66

I ported the solution from explosion/spaCy#12181 into weasel. Additionally, I have added pytest markers to identify when a test function is related with an issue, like it's set up on the spaCy repo.

Types of change

Bug fix.

Checklist

  • I confirm that I have the right to submit this contribution under the project's MIT license.
  • I ran the test suite, and all new and existing tests passed.
  • My changes don't require a change to the documentation, or if they do, I've added all required information.

@svlandeg
Copy link
Member

Thanks so much for your PR! We'll get this reviewed soonish.

@jeffrey12cali
Copy link
Contributor Author

jeffrey12cali commented Mar 20, 2024

Sorry, I didn't know about the pre-commit validation. That's why it failed on the isort module. Now it should pass.

Copy link
Member

@svlandeg svlandeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much! Really appreciate the contribution and attention to detail 🙏 Looks good - we'll get this included in the next weasel release (probably soonish).

@svlandeg svlandeg merged commit e8ae109 into explosion:main Mar 25, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error when using a file in a git repository as an asset in spacy projects config
2 participants