Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in error message #70

Closed
wants to merge 17 commits into from
Closed

Fix typo in error message #70

wants to merge 17 commits into from

Conversation

dakinggg
Copy link
Contributor

No description provided.

shadeMe and others added 17 commits August 31, 2022 19:04
* `Registry`: Optimize `get_all`

Remove superfluous copy of the global registry object and use tuple hashs for namespace comparisons.

* Restore call to `copy()` and add comment
…red-importlib-metadata

Drop python 3.6/3.7, remove vendored importlib_metadata, set version to v3.0.0
* Convert azure pipelines config to GHA

* set fail fast at false, remove cache, simplify delete dir
* Update README.md

Fix link to entry points explanation

* use link over at packaging.python.org

---------

Co-authored-by: Sofie Van Landeghem <[email protected]>
…ing (explosion#61)

`SelectableGroups` is no longer in python 3.12 and the original reason
for this design was the lack of support for `hasattr` for mypy, which
has since been resolved.
@dakinggg
Copy link
Contributor Author

@adrianeboyd @ines ?

@svlandeg
Copy link
Member

Thanks for the PR! Please don't ping individual people though - it's unnecessary and makes our Github mentions really hard to use.

Copy link
Member

@svlandeg svlandeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks!

@svlandeg
Copy link
Member

Clearly the mypy error is unrelated to this PR, but let me see if I can fix it first...

@svlandeg svlandeg deleted the branch explosion:master March 22, 2024 09:58
@svlandeg svlandeg closed this Mar 22, 2024
@svlandeg svlandeg reopened this Mar 22, 2024
@svlandeg svlandeg changed the base branch from master to v3 March 22, 2024 10:10
@svlandeg svlandeg changed the base branch from v3 to master March 22, 2024 10:10
@svlandeg
Copy link
Member

@dakinggg: the master you originally made this PR to (and the other PR) was already set up for 3.0.x, removing Python 3.6 and 3.7. However - that's not the version that spaCy currently expects. I've moved the branches around so that master points back to the 2.0.x releases, but this inadvertently adds artificial commits to this PR. I'll probably create a clean PR with your commit to the new master to resolve.

@svlandeg svlandeg marked this pull request as draft March 22, 2024 10:14
@svlandeg svlandeg closed this Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants