Ignore binary messages from MikroTik routers #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome - just what we needed! Can we make the json validation a bit more robust by trying to parse the json and catching the exception |
|
Bump @xeb |
|
Looks good. Removed the accidentally added files. |
|
Oops! Sorry about that :) you’re awesome, thanks! |
dan-online
pushed a commit
to bytebolt-media/exo
that referenced
this pull request
Aug 28, 2024
Ignore binary messages from MikroTik routers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Works on my machines!
This will ignore any MikroTik (or any other binary messages) during discovery and only process those messages that are valid JSON