Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#37 - Upgrade to version 3 spec #100

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

Hunk13
Copy link

@Hunk13 Hunk13 commented Jun 27, 2023

closes #37

Test file

require 'minitest/autorun'
require_relative 'hamming'

# Common test data version: 2.2.0 4c453c8
class HammingTest < Minitest::Test
  def test_empty_strands
    ### task_id: 1
    # skip
    assert_equal 0, Hamming.compute('', '')
  end

  def test_single_letter_identical_strands
    ### task_id: 2
    # skip
    assert_equal 0, Hamming.compute('A', 'A')
  end

  def test_single_letter_different_strands
    ### task_id: 3
    # skip
    assert_equal 1, Hamming.compute('G', 'T')
  end
end

results.json

{
  "version": 3,
  "message": null,
  "status": "pass",
  "tests": [
    {
      "name": "Empty strands",
      "status": "pass",
      "task_id": 1,
      "test_code": "assert_equal 0, Hamming.compute('', '')"
    },
    {
      "name": "Single letter identical strands",
      "status": "pass",
      "task_id": 2,
      "test_code": "assert_equal 0, Hamming.compute('A', 'A')"
    },
    {
      "name": "Single letter different strands",
      "status": "pass",
      "task_id": 3,
      "test_code": "assert_equal 1, Hamming.compute('G', 'T')"
    }
  ]
}

@Hunk13 Hunk13 requested a review from a team as a code owner June 27, 2023 15:42
@github-actions
Copy link

Hello. Thanks for opening a PR on Exercism. We are currently in a phase of our journey where we have paused community contributions to allow us to take a breather and redesign our community model. You can learn more in this blog post. As such, all issues and PRs in this repository are being automatically closed.

That doesn't mean we're not interested in your ideas, or that if you're stuck on something we don't want to help. The best place to discuss things is with our community on the Exercism Community Forum. You can use this link to copy this into a new topic there.


Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it.

@github-actions github-actions bot closed this Jun 27, 2023
@ErikSchierboom
Copy link
Member

@Hunk13 Thanks for working on this! As for the implementation, I'd like to see a chat on the forum first on the best way to implement this feature. Could you create such a topic at https://forum.exercism.org/c/programming/ruby/6?

@iHiD
Copy link
Member

iHiD commented Jul 4, 2023

I'll reopen this (so I don't lose track of it) but concur with Erik that it would be good to discuss this on the forum at a conceptual level, before moving to a technical review here :)

@iHiD iHiD reopened this Jul 4, 2023
@kotp kotp mentioned this pull request Oct 21, 2023
kotp
kotp previously approved these changes Apr 11, 2024
@kotp kotp dismissed their stale review April 11, 2024 05:46

Smoke test failing in CI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to version 3 spec
4 participants