Sync book store #850
Sync book store #850
Conversation
|
This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested. If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos. For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping |
mk-mxp
added
x:action/sync
tomasnorre
force-pushed
the
sync-book-store
branch
from
daccf53
to
1df6486
Compare
|
Do you see what's wrong in the logic, that makes the two tests fail? The linting should get a new release that fixes it within the next week. |
tomasnorre
force-pushed
the
sync-book-store
branch
from
4b59673
to
5b384ef
Compare
|
Updated to match how I did it in the go-track, in that way it works. |
|
@tomasnorre FYI: I am short of time until December. Please be patient... |
Resolves #842
There are some tests failing, with the example configuration. I had tested with my private implementation too, there some fails too.
So I don't know if some tests aren't meant for the PHP track or what the deal is yet.
I Haven't made as detailed descriptions on the additional tests, they were more confusing than helpful to me.