Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding extra pixels on left or right of image source containing a dithered image adds banding. #46

Open
sonneveld opened this issue Mar 3, 2024 · 1 comment

Comments

@sonneveld
Copy link

sonneveld commented Mar 3, 2024

With an image that contains dithering, if the scaler includes extra pixels on left or right, you can see noticeable banding. This is with with default shader and no extra scaling. Does this suggest that scaling occurs somewhere when adding extra pixels?

When taking screenshots, I did notice that taking screenshots of the source (instead of the scene) lead to screenshots with the same dimensions of 640x400, even though OBS says that it is 660x400 in the transform window after adding extra pixels.

Using OBS 29.1.3 and obs-shaderfilter 2.2.2 on Windows 10 (haven't had a chance to upgrade to newer OBS yet sorry, hopefully it's unrelated)

To test:
Add this image as a source with no scaling:
qm_001

Configure shader with extra pixels on left and right as so:
image

OBS scene screenshot without shader:
Screenshot 2024-03-04 01-11-14

OBS scene screenshot with shader:
Screenshot 2024-03-04 01-11-27

@sonneveld
Copy link
Author

sonneveld commented Sep 9, 2024

I did some experimenting and I've noticed that I don't get the same banding effect issue if I use a separate "Crop/Pad" filter before the shader filter. So there may be some differences in the implementation of "Crop/Pad" 's padding and shaderfilter's.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant