Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buffer overflow in string parameters with escaped characters #34

Open
shole opened this issue Dec 27, 2023 · 1 comment
Open

Buffer overflow in string parameters with escaped characters #34

shole opened this issue Dec 27, 2023 · 1 comment

Comments

@shole
Copy link

shole commented Dec 27, 2023

If string variable contains escaped characters, such as \", both are counted but only the " is printed, resulting in UI printing past actual string variable

Reproduction example below;

uniform string infooverflow<
    string widget_type = "info";
> = "here's some escaped \" characters: \"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\" and some more text";
uniform string stringoverflow="also works with straight string \"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"";
float4 mainImage(VertData v_in) : TARGET {
	return image.Sample(textureSampler, v_in.uv);
}

Looks like this in OBS
https://i.imgur.com/Hc7CVqU.png

@exeldro
Copy link
Owner

exeldro commented Dec 28, 2023

That looks to be a bug in OBS, not in the plugin. Let me see if I can make a fix for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants