-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to specify output s3 bucket #4
Comments
In other words, it's probably better to think of |
Looking at the code it looks like there are two classes of configurations:
Currently both of these types of options are tightly coupled in as a ServerInfo object and used in |
Yup, exactly. |
This is probably just a terminology issue but it's not clear to me what you mean by breaking them out of Mu if Mu needs Class 1 options to function. My initial thought was to have a matching .cfg file for each server with just Class 1 options that can be validated in a checking stage like you've mentioned in #3. Then as usual the user can do whatever they want with their Class 2 options. |
Sorry, I should have clarified in my previous answer that "breaking out" should only apply to class 2, as you say. |
Output s3 buckets are hardcoded based on the name of the input parameters:
outName = "%s-y4m_%02d" % (ServerInfo.video_name, ServerInfo.num_frames)
ServerInfo should have another option to specify an output s3 bucket, else use the default parameters.
The text was updated successfully, but these errors were encountered: