feature/#75 add support for project license auditing #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkilias
reviewed
Jul 6, 2023
| that it is an opt in, controlled by the "user/client". | ||
|
|
||
| Replacing pylint with an alternative (like `ruff <https://github.com/astral-sh/ruff>`_) | ||
| with a more would remove the ambiguity and need for justification. |
There was a problem hiding this comment.
Suggested change
| with a more would remove the ambiguity and need for justification. | |
| with a more permissive license would remove the ambiguity and need for justification. |
tkilias
reviewed
Jul 6, 2023
| "-m", | ||
| "piplicenses", | ||
| "--packages", | ||
| *packages, |
There was a problem hiding this comment.
in that case you must hope, that you don't have more packages as the command line allows parameters.https://www.cyberciti.biz/faq/linux-unix-arg_max-maximum-length-of-arguments/
There was a problem hiding this comment.
Nicoretti
force-pushed
the
feature/#75-add-support-for-project-license-auditing
branch
from
ae6ac61
to
4e7826d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #75
✔ Checklist(s)
Note: If any of the above is not relevant to your PR just check the box.