remove code for coloring process row that no longer exists

[#158931754]

Co-authored-by: Alex Zhao <[email protected]>

Author: XenoPhex

command/ui.go

@@ -17,7 +17,6 @@ type UI interface {
 	DisplayInstancesTableForApp(table [][]string)
 	DisplayKeyValueTable(prefix string, table [][]string, padding int)
 	DisplayKeyValueTableForApp(table [][]string)
-	DisplayKeyValueTableForV3App(table [][]string, crashedProcesses []string)
 	DisplayLogMessage(message ui.LogMessage, displayHeader bool)
 	DisplayNewline()
 	DisplayNonWrappingTable(prefix string, table [][]string, padding int)

command/v3/shared/app_summary_displayer.go

@@ -88,33 +88,24 @@ func (display AppSummaryDisplayer) displayAppTable(summary v3action.ApplicationS
 		isoRow = append(isoRow, display.UI.TranslateText("isolation segment:"), appStats[0].IsolationSegment)
 	}
 
-	keyValueTable := [][]string{
-		{display.UI.TranslateText("name:"), summary.Application.Name},
-		{display.UI.TranslateText("requested state:"), strings.ToLower(string(summary.State))},
-		isoRow,
-		{display.UI.TranslateText("routes:"), routes.Summary()},
-		{display.UI.TranslateText("last uploaded:"), display.UI.UserFriendlyDate(GetCreatedTime(summary))},
-		{display.UI.TranslateText("stack:"), summary.CurrentDroplet.Stack},
-	}
-
 	var lifecycleInfo []string
-
 	if summary.LifecycleType == constant.AppLifecycleTypeDocker {
 		lifecycleInfo = []string{display.UI.TranslateText("docker image:"), summary.CurrentDroplet.Image}
 	} else {
 		lifecycleInfo = []string{display.UI.TranslateText("buildpacks:"), display.buildpackNames(summary.CurrentDroplet.Buildpacks)}
 	}
 
-	keyValueTable = append(keyValueTable, lifecycleInfo)
-
-	crashedProcesses := []string{}
-	for i := range summary.ProcessSummaries {
-		if display.processInstancesAreAllCrashed(&summary.ProcessSummaries[i]) {
-			crashedProcesses = append(crashedProcesses, summary.ProcessSummaries[i].Type)
-		}
+	keyValueTable := [][]string{
+		{display.UI.TranslateText("name:"), summary.Application.Name},
+		{display.UI.TranslateText("requested state:"), strings.ToLower(string(summary.State))},
+		isoRow,
+		{display.UI.TranslateText("routes:"), routes.Summary()},
+		{display.UI.TranslateText("last uploaded:"), display.UI.UserFriendlyDate(GetCreatedTime(summary))},
+		{display.UI.TranslateText("stack:"), summary.CurrentDroplet.Stack},
+		lifecycleInfo,
 	}
 
-	display.UI.DisplayKeyValueTableForV3App(keyValueTable, crashedProcesses)
+	display.UI.DisplayKeyValueTable("", keyValueTable, 3)
 
 	display.displayProcessTable(summary)
 }

util/ui/ui_for_app.go

@@ -29,33 +29,3 @@ func (ui *UI) DisplayKeyValueTableForApp(table [][]string) {
 	}
 	ui.DisplayKeyValueTable("", table, 3)
 }
-
-func (ui *UI) DisplayKeyValueTableForV3App(table [][]string, crashedProcesses []string) {
-	if len(crashedProcesses) > 0 {
-		redColor := color.New(color.FgRed, color.Bold)
-		table[1][1] = ui.modifyColor(table[1][1], redColor)
-
-		processes := strings.Split(table[2][1], ",")
-		newProcesses := []string{}
-		for _, process := range processes {
-			parts := strings.Split(process, ":")
-			isCrashedProcess := false
-			for _, crashedProcess := range crashedProcesses {
-				if parts[0] == crashedProcess {
-					isCrashedProcess = true
-					break
-				}
-			}
-
-			if isCrashedProcess {
-				newProcesses = append(newProcesses, ui.modifyColor(process, redColor))
-			} else {
-				newProcesses = append(newProcesses, process)
-			}
-		}
-
-		table[2][1] = strings.Join(newProcesses, ",")
-	}
-
-	ui.DisplayKeyValueTable("", table, 3)
-}

util/ui/ui_for_app_test.go

@@ -29,57 +29,6 @@ var _ = Describe("UI", func() {
 		ui.Err = NewBuffer()
 	})
 
-	Describe("DisplayKeyValueTableForV3App", func() {
-		Context("when the app is running properly", func() {
-			BeforeEach(func() {
-				ui.DisplayKeyValueTableForV3App([][]string{
-					{"name:", "dora"},
-					{"requested state:", "started"},
-					{"processes:", "web:1/1,worker:2/2"}},
-					[]string{},
-				)
-			})
-
-			It("displays a table with the no change in coloring", func() {
-				Expect(ui.Out).To(Say("name:              dora\n"))
-				Expect(ui.Out).To(Say("requested state:   started\n"))
-				Expect(ui.Out).To(Say("processes:         web:1/1,worker:2/2\n"))
-			})
-		})
-
-		Context("when the app is stopped and has 0 instances", func() {
-			BeforeEach(func() {
-				ui.DisplayKeyValueTableForV3App([][]string{
-					{"name:", "dora"},
-					{"requested state:", "stopped"},
-					{"processes:", "web:1/1,worker:2/2"}},
-					[]string{})
-			})
-
-			It("displays a table with the no change in coloring", func() {
-				Expect(ui.Out).To(Say("name:              dora\n"))
-				Expect(ui.Out).To(Say("requested state:   stopped\n"))
-				Expect(ui.Out).To(Say("processes:         web:1/1,worker:2/2\n"))
-			})
-		})
-
-		Context("when the app is started and has 1 crashed process", func() {
-			BeforeEach(func() {
-				ui.DisplayKeyValueTableForV3App([][]string{
-					{"name:", "dora"},
-					{"requested state:", "started"},
-					{"processes:", "web:0/1,worker:2/2"}},
-					[]string{"web"})
-			})
-
-			It("displays a table with requested state and crashed instance count in red", func() {
-				Expect(ui.Out).To(Say("name:              dora\n"))
-				Expect(ui.Out).To(Say("requested state:   \x1b\\[31;1mstarted\x1b\\[0m\n"))
-				Expect(ui.Out).To(Say("processes:         \x1b\\[31;1mweb:0/1\x1b\\[0m,worker:2/2\n"))
-			})
-		})
-	})
-
 	Describe("DisplayInstancesTableForApp", func() {
 		Context("in english", func() {
 			It("displays a table with red coloring for down and crashed", func() {