ask edit toggle #6346
Merged
ask edit toggle #6346
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for remixproject ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Can you describe the changes? it doesn't seem to be only related to ask/edit. |
yann300
reviewed
Sep 9, 2025
|
|
||
| await this.plugin.call('fileManager', 'writeFile', file.fileName, "") | ||
| await new Promise(resolve => setTimeout(resolve, 2000)) // wait so the content is written before diffing | ||
| await this.plugin.call('editor', 'showCustomDiff', file.fileName, file.content) |
There was a problem hiding this comment.
I think you don't need to show a custom diff in that case as the file is new.
There was a problem hiding this comment.
@yann300 actually you need to show a diff to be compliant to make users asserting any changes
yann300
approved these changes
Sep 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.