-
Notifications
You must be signed in to change notification settings - Fork 332
Open
Labels
A-toolArea: toolingArea: toolingC-enhanceCategory: a request for an improvementCategory: a request for an improvementE-mediumExperience: of moderate difficultyExperience: of moderate difficultyP-medium
Milestone
Description
End Goal
Enable two command-lines that lint, respectively check source formatting, across the entire post-weld codebase:
# lint (flake8)
ruff check --no-fix --show-fixes src tests
# format (black)
ruff format --check src tests
Status Quo
- EELS and EEST use different ruff rules.
- EELS doesn't use
ruff format
. - EELS doesn't lint/format
./tests
. - EEST needs to reformat 99 -> 79.
Sub-tasks
Pre-Switch
- BOTH: chore(tooling): agree on common post-weld ruff rules #1403
- EELS: chore(tooling): add missing code formatting checks (
ruff format --check
) #1397 - EELS: Enable
ruff
on all source undertests
. - EEST: Consider fixing comment and docstring lines(<79) in EEST to enable a faster/smoother Switch.
At Switch
After EEST freeze & sub-tree update; PR in EELS:
- Re-format EEST code w/79.
- Update tox.ini to unify
ruff
commands.
fselmo
Metadata
Metadata
Assignees
Labels
A-toolArea: toolingArea: toolingC-enhanceCategory: a request for an improvementCategory: a request for an improvementE-mediumExperience: of moderate difficultyExperience: of moderate difficultyP-medium