Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove data already present in tokens list #8

Open
spalladino opened this issue Oct 12, 2021 · 0 comments
Open

Remove data already present in tokens list #8

spalladino opened this issue Oct 12, 2021 · 0 comments
Labels
discussion Discussions regarding the schemas and data management

Comments

@spalladino
Copy link
Collaborator

Resuming here a suggestion by @ligi :

Removed some extra spaces - also wondering if we should DRY up the tokens and just reference to the tokens repo - feels a bit WET this way

We are currently duplicating two sets of info: 1) info on the token contract (symbol, decimals, name, etc) and 2) on the project (github, support email, etc).

Regarding (1), we could drop symbol, decimals, and name, and just reference the address, so clients can use it to retrieve the missing info from the tokens list. On the other hand, these are attributes that rarely change, and including them here can save a client a roundtrip to the tokens list.

As for (2), I agree that it is info more annoying to track in both places. However, I can see a case where a project is not identified by a token, so we don't have an entry to reference.

Thoughts?

@spalladino spalladino added the discussion Discussions regarding the schemas and data management label Oct 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion Discussions regarding the schemas and data management
Projects
None yet
Development

No branches or pull requests

2 participants
@spalladino and others