Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support prometheus metrics out of the box #6795

Open
Loki-Afro opened this issue Dec 10, 2024 · 2 comments
Open

support prometheus metrics out of the box #6795

Loki-Afro opened this issue Dec 10, 2024 · 2 comments

Comments

@Loki-Afro
Copy link

Loki-Afro commented Dec 10, 2024


name: Feature request
about: support prometheus metrics out of the box


Is your feature request related to a problem? Please describe.
the current metrics endpoint returns json, that is not suitable for a prometheus scraper

Describe the solution you'd like
maybe replace node-measured with https://github.com/open-telemetry/opentelemetry-js which is actively maintained, maybe you know a better one ..

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.
node-measured appears to be dead for 4 years or more yaorg/node-measured#82

Plugin?
maybe? but then i think node-measured should still be removed as it appears to be dead

@JohnMcLear
Copy link
Member

Can you please explain why? You have said "I want software X, not Y" but how does anyone get positively impacted by this?

Why would this request NOT be a plugin? It feels to me like this is an addon/feature that is perfect to be a plugin..

@Loki-Afro
Copy link
Author

@JohnMcLear
https://github.com/yaorg/node-measured last release from 2020, it is part of etherpad without any plugin.
so i assume using something actively maintained that probably benefits more users since opentelemetry-js can be configured further is a clear reason why i think this would be a better choice.

if you go the plugin path, which might be valid too, i would argue for removing node-measured as well and or provide it as a plugin.

maybe also interesting to you: #6793

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants