Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/stats appears to be unprotected, no api key required #6793

Open
Loki-Afro opened this issue Dec 10, 2024 · 0 comments
Open

/stats appears to be unprotected, no api key required #6793

Loki-Afro opened this issue Dec 10, 2024 · 0 comments

Comments

@Loki-Afro
Copy link

Loki-Afro commented Dec 10, 2024

Describe the bug
A clear and concise description of what the bug is.

To Reproduce
Steps to reproduce the behavior:

  1. start etherpad, regardless in what mode
  2. go to 'http://localhost:9001/stats'

Expected behavior
/stats should only be available with the given api key, maybe even by default disabled

Server (please complete the following information):

  • Etherpad version: 2.0.1-2.2.6, probably also earlier versions affected
  • OS: container
  • Is the server free of plugins: yes

Additional Context:
i do believe that exposing /stats while being unauthenticated is a security risk

  • either apply the logic with the api key
  • or better in my opinion disable the /metrics endpoint by default

i would favor the later because enabling that endpoint is an explicit action, if you do that, you probably don't want to also expose it in your reverse proxy or similar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant