Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker: ADMIN_PASSWORD is not passing #6791

Open
Langoor2 opened this issue Dec 8, 2024 · 1 comment
Open

Docker: ADMIN_PASSWORD is not passing #6791

Langoor2 opened this issue Dec 8, 2024 · 1 comment

Comments

@Langoor2
Copy link

Langoor2 commented Dec 8, 2024

Describe the bug
Setup a clean etherpad with mariadb database, as according to the instructions on the Wiki.
If i set "ADMIN_PASSWORD" to any value, this value is not passed/parsed correctly, in the config i can see that it is still set to the default admin password.

To Reproduce
Steps to reproduce the behavior:

  1. set "ADMIN_PASSWORD" with docker
  2. login to the /admin/ ui
  3. the default admin/admin credentials are always accepted
  4. in the currently running settings you can see that it is using admin/admin

Expected behavior
It uses the admin password I configured

Screenshots
If applicable, add screenshots to help explain your problem.

Server (please complete the following information):

  • Etherpad version: 2.2.6
  • OS: Ubuntu 22.04
  • Node.js version (node --version): came with docker image
  • npm version (npm --version): pnpm --version: 9.0.4
  • Is the server free of plugins: Yes

Additional context
docker compose:

services:
  app:
    user: "0:0"
    image: etherpad/etherpad:latest
    tty: true
    stdin_open: true
    volumes:
      - plugins:/opt/etherpad-lite/src/plugin_packages
      - etherpad-var:/opt/etherpad-lite/var
    environment:
      NODE_ENV: production
      ADMIN_PASSWORD: xXx1234aBcDe
      DB_HOST: ${DOCKER_GATEWAY_HOST:-host.docker.internal}
      DB_NAME: etherpad_db
      DB_PASS: xxxxxx
      DB_PORT: 3306
      DB_TYPE: mysql
      DB_USER: etherpaduser
      DB_CHARSET: utf8mb4
      # For now, the env var DEFAULT_PAD_TEXT cannot be unset or empty; it seems to be mandatory in the latest version of etherpad
      DEFAULT_PAD_TEXT: ${DOCKER_COMPOSE_APP_DEFAULT_PAD_TEXT:- }
      DISABLE_IP_LOGGING: ${DOCKER_COMPOSE_APP_DISABLE_IP_LOGGING:-false}
      SOFFICE: ${DOCKER_COMPOSE_APP_SOFFICE:-null}
      TRUST_PROXY: ${DOCKER_COMPOSE_APP_TRUST_PROXY:-true}
    restart: always
    ports:
      - "${DOCKER_COMPOSE_APP_PORT_PUBLISHED:-9001}:${DOCKER_COMPOSE_APP_PORT_TARGET:-9001}"

volumes:
  plugins:
  etherpad-var:
@grobitec
Copy link

grobitec commented Dec 13, 2024

Hello.
Many thanks for the maintenance and development of etherpad.

Unfortunately I encountered a similar problem:
my setup:

  • portainer
  • stack from github
  • set two environment variables:
    • DOCKER_COMPOSE_APP_PORT_PUBLISHED and
    • DOCKER_COMPOSE_APP_ADMIN_PASSWORD

That means I use exactly the standard docker-compose.yml file from the etherpad-lite repository.
The only thing I changed is the port and the password

If I deploy the stack like this, all ehtherpad functions work and the port is also mapped correctly.

Only logging in as admin doesn't work.

If I connect to the container interactively and display the environment variables, the value I set is under ADMIN_PASSWORD.
But login fails with username: admin and password: hello1233456
And login also fails with username: admin and password: admin.

What could that be about?

Thanks for the help.

Frontend:
grafik
Portainer:
grafik
Container:
grafik

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants