New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Navigating on mouse down is bad for accessibility #49

Open

joshuajaco opened this issue Oct 21, 2024 · 1 comment · May be fixed by #61

joshuajaco commented Oct 21, 2024

Navigating on mouse down instead of mouse up is bad for accessibility for several reasons:

It breaks the ability to drag and drop links.
You cannot "cancel" the navigation. (I often click something and, before releasing, realize I wanted to click something else.)
It can cause scrolling issues on mobile, where I only want to scroll but accidentally trigger navigation.

People expect links to work on mouse up and have adapted their workflows accordingly.

Relevant code: https://github.com/ethanniser/NextMaster/blob/24f8acae72bfb1bb7969b86b002f3a2a9c3cdc06/src/components/ui/link.tsx#L105

joshuajaco changed the title ~~Navigating on mouse down is bad accssibility~~ Navigating on mouse down is bad for accessibility

joshuajaco linked a pull request

that will close this issue

Remove navigation on mouse down #61

Open

dvartic commented Oct 27, 2024 •

edited

Loading

It's a tradeoff.

Don't drag and drop links.
Revert your action through other means.
Mousedown on mobile gets triggered the same as click: when you lift your finger son there are no issues here.

People expecations should not dictate potential improvements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment