Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use cursor instead of first counting new files and then getting them #362

Open
MaxiBoether opened this issue Jan 11, 2024 · 0 comments
Open
Labels

Comments

@MaxiBoether
Copy link
Contributor

The Storage gRPC service, when checking for new files, first gets the number of new files to allocate a vector of the correct size, and then basically executes the same query again, this time dumping the actual data into the vector. The reason is that soci expects the vector to have a sufficient size.

To solve this, we could try and use a cursor instead, since we know we will be getting fixed size chunks there. Then we avoid doing the same work twice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant