Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rethink bookkeeping of PipelineStage per pipeline #343

Open
jenny011 opened this issue Dec 19, 2023 · 1 comment
Open

Rethink bookkeeping of PipelineStage per pipeline #343

jenny011 opened this issue Dec 19, 2023 · 1 comment

Comments

@jenny011
Copy link
Collaborator

In #317 , a PipelineExecutor instance keeps track of a PipelineStage which is reported to the client. The PipelineStage is updated and used not only in PipelineExecutor, but also in the GRPCHandler (instantiated per PipelineExecutor) and relevant code that are part of the pipeline logic.
Currently, the GRPCHandler and relevant code has no access to the PipelineStage stored at the PipelineExecutor. However, the GRPCHandler and relevant code also reports a pipeline stage to the client. This pipeline stage is hardcoded.
We would like to refactor the code so that

  1. the PipelineStage, if reported to the client, is always bookkept at the PipelineExecutor instead of hardcoded.
  2. logic about the PipelineStage is not scattered in multiple places.
@robinholzi
Copy link
Collaborator

Partially addressed: We now maintain the PipelineStage centrally through PipelineExecutor decorators. However, ambiguity still exists in the GRPC client interface. I'm not sure how much value it provides to also fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants