Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2024-11-04] Manual Dependency Bump #18840

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

[2024-11-04] Manual Dependency Bump #18840

wants to merge 5 commits into from
+141 −117

Conversation

ArkaSaha30
Copy link
Contributor

@ArkaSaha30 ArkaSaha30 commented Nov 5, 2024 •
edited
Loading

Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.

This pull request completes this week's etcd dependency updates following our dependency roster and dependency management instructions.

Dependabot raised the following PRs:

Bumped:

Purely Indirect:

@ArkaSaha30
dependency: bump github.com/golang-jwt/jwt/v4 from 4.5.0 to 4.5.1
fed92fa 
This commit will bump dependency github.com/golang-jwt/jwt/v4 from 4.5.0 to 4.5.1

Signed-off-by: ArkaSaha30 <[email protected]>
@ArkaSaha30
dependency: bump github.com/grpc-ecosystem/grpc-gateway/v2 from 2.22.…
84096c6 
…0 to 2.23.0

This commit will bump dependency github.com/grpc-ecosystem/grpc-gateway/v2 from 2.22.0 to 2.23.0

Signed-off-by: ArkaSaha30 <[email protected]>
@ArkaSaha30
dependency: bump go.etcd.io/bbolt from 1.4.0-alpha.1 to 1.4.0-beta.0
19564cb 
This commit will bump dependency go.etcd.io/bbolt from 1.4.0-alpha.1 to 1.4.0-beta.0

Signed-off-by: ArkaSaha30 <[email protected]>
@ArkaSaha30
dependency: bump github.com/google/yamlfmt from 0.13.0 to 0.14.0
5899e4d 
This commit will bump dependency github.com/google/yamlfmt from 0.13.0 to 0.14.0

Signed-off-by: ArkaSaha30 <[email protected]>
@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ArkaSaha30
Once this PR has been reviewed and has the lgtm label, please assign ahrtr for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ArkaSaha30 ArkaSaha30 changed the title Deps mgmt 4 11 24 [2024-11-04] Manual Dependency Bump Nov 5, 2024
@codecov-commenter
Copy link

codecov-commenter commented Nov 5, 2024 •
edited
Loading

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.77%. Comparing base (bd88963) to head (aa50c1a).

❗ Current head aa50c1a differs from pull request most recent head fdb7302

Please upload reports for the commit fdb7302 to get more accurate results.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

see 23 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #18840      +/-   ##
==========================================
- Coverage   68.78%   68.77%   -0.01%     
==========================================
  Files         420      420              
  Lines       35523    35522       -1     
==========================================
- Hits        24433    24429       -4     
- Misses       9665     9667       +2     
- Partials     1425     1426       +1

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd88963...fdb7302. Read the comment docs.

@ArkaSaha30
fix genproto error
fdb7302 
Signed-off-by: ArkaSaha30 <[email protected]>
@ArkaSaha30
Copy link
Contributor Author

/retest pull-etcd-unit-test-386

@k8s-ci-robot
Copy link

@ArkaSaha30: The /retest command does not accept any targets.
The following commands are available to trigger required jobs:

  • /test pull-etcd-build
  • /test pull-etcd-e2e-386
  • /test pull-etcd-e2e-amd64
  • /test pull-etcd-e2e-arm64
  • /test pull-etcd-govulncheck
  • /test pull-etcd-integration-1-cpu-amd64
  • /test pull-etcd-integration-1-cpu-arm64
  • /test pull-etcd-integration-2-cpu-amd64
  • /test pull-etcd-integration-2-cpu-arm64
  • /test pull-etcd-integration-4-cpu-amd64
  • /test pull-etcd-integration-4-cpu-arm64
  • /test pull-etcd-robustness-amd64
  • /test pull-etcd-robustness-arm64
  • /test pull-etcd-unit-test-386
  • /test pull-etcd-unit-test-amd64
  • /test pull-etcd-unit-test-arm64
  • /test pull-etcd-verify

Use /test all to run all jobs.

In response to this:

/retest pull-etcd-unit-test-386

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ArkaSaha30
Copy link
Contributor Author

/retest-required

@ivanvc
Copy link
Member

ivanvc commented Nov 6, 2024 •
edited
Loading

Question, should we squash commits 84096c6 and fdb7302, as technically updating github.com/grpc-ecosystem/grpc-gateway/v2 (84096c6) was the change that updated api/etcdserverpb/gw/rpc.pb.gw.go and therefore caused fdb7302?

@ivanvc ivanvc mentioned this pull request Nov 6, 2024
Closed
@ahrtr
Copy link
Member

ahrtr commented Nov 6, 2024

Question, should we squash commits 84096c6 and fdb7302, as technically updating github.com/grpc-ecosystem/grpc-gateway/v2 (84096c6) was the change that updated api/etcdserverpb/gw/rpc.pb.gw.go and therefore caused fdb7302?

@ArkaSaha30 can you please add more context to the commit message for the commit "fix genproto error" for future reference?

  • Why there is such error?
  • How did you fix the genproto error? manually or automatically?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area/clientv3 area/etcdctl area/etcdutl area/testing area/tooling size/L
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ArkaSaha30 @k8s-ci-robot @codecov-commenter @ivanvc @ahrtr