Skip to content

Conversation

@frederiko
Copy link
Contributor

This small refactor proposes deprecating prepareOwnerReferences in favor of controllerutils.SetControllerReference.

@k8s-ci-robot
Copy link

Hi @frederiko. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@frederiko frederiko changed the title Deprecate prepareOwnerReference in favor of controllerutils methods Deprecate prepareOwnerReference in favor of controllerutils Aug 25, 2025
@ahrtr
Copy link
Member

ahrtr commented Aug 26, 2025

/ok-to-test

Copy link
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really a nice cleanup.

It's be better to add an e2e test to verify that the statefulSets, headless service and configMap have the correct ownerReference set. It's OK to resolve it in a separate PR. Could you raise an issue to track it? thx

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, frederiko

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ahrtr ahrtr merged commit e89aeb6 into etcd-io:main Aug 27, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants