Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getTopOriginsThatNeedSomeLove() calculation is not fully correct #105

Open
sharon-wang opened this issue Dec 31, 2020 · 0 comments
Open
Labels
bug Something isn't working

Comments

@sharon-wang
Copy link
Member

If a user spends time on a site without a payment provider (i.e. Coil), we’ll have monetized time spent (unpaid, i.e. no payment streamed) logged for them. However, as soon as they start streaming payment to sites, the monetized time spent will reflect both unpaid and paid monetized time spent.

This makes the needs love calculation faulty because our intention is to boost sites that the user has not streamed much payment to (low amount of paid monetized time), not just boosting sites with a low amount of monetized time in general.

This means that we'll either need to track both paid monetized time and unpaid monetized time per origin, or we'll need to sum up all sent assets to an origin, convert to a single currency and compare the total sent amount between origins to deduce the origins that need some love. The former option would be the simplest (but would require a change to our data format), since converting to a single currency requires a lot more calculation and we'd need to use an exchange rate API of some sort.

@sharon-wang sharon-wang added the bug Something isn't working label Dec 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant