Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add ci for qemu tests #253

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

horw
Copy link
Member

@horw horw commented Jan 2, 2024

This pull request adds support for QEMU tests to the project's CI pipeline: installs necessary dependencies, and runs tests using QEMU.

Copy link
Member

@hfudev hfudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Worth to mention that, after #255 got merged, one ARM-based runner will be enabled as well.

please rebase after that one got merged, and download qemu only on X64 one.

@hfudev
Copy link
Member

hfudev commented Jan 2, 2024

rebased to run the tests

@horw
Copy link
Member Author

horw commented Jan 8, 2024

I fixed the related dependencies, and now it works. However, there are problems with some tests, specifically with the expectation the menu debug_str = 'Not found "[\'Press ENTER to see the list of tests\', \'Enter test for running\', "Enter next test, or \'enter\' to s...lease check the full log here: /tmp/pytest-embedded/2024-01-08_06-34-26-407301/test_qemu_use_idf_mixin_methods/dut.log'

@horw horw force-pushed the ci/qemu_test_env branch 7 times, most recently from 75656a8 to 678b5cb Compare January 9, 2024 06:40
Copy link
Member

@hfudev hfudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's pick this PR back. I've left a new comment and rebased the branch.

# here we can't use confirm_write because the sub cases won't print anything
# can't rely on time.sleep either cause it will break some time-related child cases
self.write(str(sub_case['index']))
self.confirm_write(str(sub_case['index']), expect_str=f"Running stage {sub_case['index']}...")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's revert this line and test with normal single dut test cases.

Copy link
Member

@hfudev hfudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's pick this PR back. I've left a new comment and rebased the branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants