Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(usb): Change critical section API #74

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

peter-marcisovsky
Copy link
Collaborator

Description

As per idf-core team recommendations, this MR updates a Critical section API to a new one.

Related

Closes IDF-11361

Testing

To pass CI tests


Checklist

Before submitting a Pull Request, please ensure the following:

  • 🚨 This PR does not introduce breaking changes.
  • All CI checks (GH Actions) pass.
  • Documentation is updated as needed.
  • Tests are updated or added as necessary.
  • Code is well-commented, especially in complex areas.
  • Git history is clean — commits are squashed to the minimum necessary.

@peter-marcisovsky
Copy link
Collaborator Author

peter-marcisovsky commented Oct 7, 2024

esp_private/critical_section.h is not present in IDF 5.0.
Updating to new critical section API is a preparation for IDF 6.0 support. By the time IDF 6.0 is released, IDF 5.0 will probably go EOL, and we will be able to merge this. On hold for now.

@peter-marcisovsky peter-marcisovsky self-assigned this Oct 8, 2024
@tore-espressif tore-espressif marked this pull request as draft November 15, 2024 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant