GroupCluster allways reports GroupNameSupport even if config is set to false (CON-1432)

[Haerteleric]

Describe the bug

cluster::groups::config_t groupsConfig;
groupsConfig.group_name_support = false;
cluster_t *groupCluster = cluster::groups::create(endpoint, &groupsConfig, CLUSTER_FLAG_SERVER);

should result in

global::attribute::create_feature_map(cluster, 0);

but in esp_matter::cluster::groups::create() (esp_matter_cluster.cpp:1233)

it is hardcoded to:

global::attribute::create_feature_map(cluster, 1);

[Haerteleric]

This causes issues at Matter Cert Lab. As the PICS files are incorrect because of it.

[jonsmirl]

Why do you want to turn it off? It only consumes around 50 bytes of flash, and I like giving my groups human friendly names.

[jadhavrohit924]

@Haerteleric If you check the latest spec, GroupNameSupport is mandatory on the groups cluster. BTW, which branch/commit you are using?

[Haerteleric]

i agree, that there is no obvious reason to disable that. But if disabled the featureMap should be set accordingly.

[jadhavrohit924]

Yes, that’s why I asked you for the branch/commit that you are using.

groupsConfig.group_name_support = false;

I'm not sure where you got that. If you check the latest main branch we don’t have any such config in the groups cluster. If it's an attribute that you are referring you cannot set it to false. To get a better understanding of your issue, I would need a branch/commit id that you are using. Will it be possible to share?

[Haerteleric]

im using the esp-matter as a component (v1.3.0) on esp-idf v5.4.0 (46acfdce969f03c02b001fe4d24fa9e98f6adc5e).

the groupsConfig is in the extended_color_light::config_t struct.
esp_matter_endpoint.h:219

i just checked the same file in the main branch and it has indeed been reworked.

[jadhavrohit924]

I was talking about the group_name_support under the groups cluster. It's not in the SDK, what is group_name_support that you have set to false. Please share the details of the group_name_support. Did you add any patch on top of esp-matter? If yes, please share it with me.

[Haerteleric]

I'm using https://components.espressif.com/components/espressif/esp_matter

this uses the 1.3 Branch of this repo. via https://github.com/espressif/esp-matter/.

in my project i create a extended color light EP using this struct:

esp-matter/components/esp_matter/esp_matter_endpoint.h

Line 223 in 552b6f8

cluster::groups::config_t groups;

the flag in question can be found here :

esp-matter/components/esp_matter/esp_matter_cluster.h

Line 305 in 552b6f8

uint8_t group_name_support;

[jadhavrohit924]

Okay, so group_name_support here doesn’t represent a feature, and it's of type bitmap8 in the spec, so you cannot set it to false. In general, features represent attributes, commands, and events, not vice versa.

[shubhamdp]

@Haerteleric please check 2ef7fc5 commit message has some details why it is always enabled.

(50a40b9 -- minor fix for the bug in prior commit)

[shubhamdp]

I'd suggest you to toggle that feature bit in the PICS file.