Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update minimatch #66

Open
1 of 5 tasks
benmccann opened this issue Jun 24, 2024 · 4 comments
Open
1 of 5 tasks

Update minimatch #66

benmccann opened this issue Jun 24, 2024 · 4 comments
Labels
enhancement New feature or request

Comments

@benmccann
Copy link

Which packages would you like to change?

  • @eslint/compat
  • @eslint/config-array
  • @eslint/migrate-config
  • @eslint/object-schema

What problem do you want to solve?

Upgrading to a newer version would reduce the number of dependencies and allow the remaining dependencies to dedupe better

"minimatch": "^3.1.2"

What do you think is the correct solution?

version 9 is now available. if it's a difficult upgrade perhaps upgrading to an intermediate version would be an easier step

Participation

  • I am willing to submit a pull request for this change.

Additional comments

No response

@benmccann benmccann added the enhancement New feature or request label Jun 24, 2024
@mdjermanovic
Copy link
Member

We're using minimatch v3 in ESLint too, for both flat and eslintrc config functionalities. We're also using minimatch v3 in @eslint/eslintrc, which is still a dependency of ESLint. So if we upgrade only here, there will still be minimatch v3 in the dependency tree, which is probably not what we want. Since we'd prefer not to make any changes in eslintrc code at this point, I think it would be better to postpone this upgrade for ESLint v10, when we'll remove everything related to eslintrc.

@eslint/eslint-tsc thoughts?

@nzakas
Copy link
Member

nzakas commented Jun 24, 2024

IIRC, the reason we haven't upgraded is because it looked like there were some changes in functionality that caused our tests to break. I don't see any compelling reason to upgrade right now.

We can definitely think about this for v10, though we should keep in mind that this package will be depended by v9 as well, which should affect how we manage semver around this.

@bluwy

This comment was marked as off-topic.

@nzakas
Copy link
Member

nzakas commented Jul 30, 2024

@bluwy we aren't looking for reasons to upgrade. As already mentioned, when we tried upgrading before it broke some behavior so that's the key consideration here.

@eslint eslint locked as off-topic and limited conversation to collaborators Jul 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
Status: Blocked
Development

No branches or pull requests

4 participants