-
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update minimatch
#66
Comments
We're using minimatch v3 in ESLint too, for both flat and eslintrc config functionalities. We're also using minimatch v3 in @eslint/eslint-tsc thoughts? |
IIRC, the reason we haven't upgraded is because it looked like there were some changes in functionality that caused our tests to break. I don't see any compelling reason to upgrade right now. We can definitely think about this for v10, though we should keep in mind that this package will be depended by v9 as well, which should affect how we manage semver around this. |
This comment was marked as off-topic.
This comment was marked as off-topic.
@bluwy we aren't looking for reasons to upgrade. As already mentioned, when we tried upgrading before it broke some behavior so that's the key consideration here. |
Which packages would you like to change?
@eslint/compat
@eslint/config-array
@eslint/migrate-config
@eslint/object-schema
What problem do you want to solve?
Upgrading to a newer version would reduce the number of dependencies and allow the remaining dependencies to dedupe better
rewrite/packages/config-array/package.json
Line 51 in 8501890
What do you think is the correct solution?
version 9 is now available. if it's a difficult upgrade perhaps upgrading to an intermediate version would be an easier step
Participation
Additional comments
No response
The text was updated successfully, but these errors were encountered: