Refactor so that new rules can be easily added #9
Labels
Comments
pmcelhaney
pushed a commit
to pmcelhaney/eslint-transforms
that referenced
this issue
Dec 31, 2017
To add a new transform: 1. Create a directory under tests/fixtures/transforms 2. Add the test fixtures (*.input.js, *.output.js, and *.md) 3. Implement the transform in lib/transforms There's no need to create new (Mocha) test file. At this point, documenting the transform is still manual, but it could be easily automated.
pmcelhaney
pushed a commit
to pmcelhaney/eslint-transforms
that referenced
this issue
Dec 31, 2017
To add a new transform: 1. Create a directory under tests/fixtures/transforms 2. Add the test fixtures (*.input.js, *.output.js, and *.md) 3. Implement the transform in lib/transforms There's no need to create new (Mocha) test file. At this point, documenting the transform is still manual, but it could be easily automated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This repository currently only contains one transform. It's tested by looping over fixture files with
<test>.input.jsand<test>.output.js.There's no reason we shouldn't be able to use the same test for additional transforms and provide a new set of fixtures for each transform.
We can also automatically the scan the fixtures directory rather than referencing each one in the test file.
The only question is what to do with the comments describing each transform. I'm going to solve that by creating a
<test>.mdfile for each of the fixtures. In the future, we could write a script to automatically generate documentation that collects everything in one place.The text was updated successfully, but these errors were encountered: